From 582695245e6ce2bafaf3b11b9d3b69dcf88d0037 Mon Sep 17 00:00:00 2001 From: Pierre-Hugues Husson Date: Mon, 5 Aug 2019 17:27:47 +0200 Subject: [PATCH 08/11] Fix use-after-free (object on stack) Change-Id: I9ae666b10873eac4e7a55032071e7b15b0de058a --- .../audiopolicy/common/managerdefinitions/src/Serializer.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/services/audiopolicy/common/managerdefinitions/src/Serializer.cpp b/services/audiopolicy/common/managerdefinitions/src/Serializer.cpp index c8cb54b5f..9f2bdc4b3 100644 --- a/services/audiopolicy/common/managerdefinitions/src/Serializer.cpp +++ b/services/audiopolicy/common/managerdefinitions/src/Serializer.cpp @@ -517,7 +517,7 @@ Return DevicePortTraits::deserialize(const xmlNode *c if (!encodedFormatsLiteral.empty()) { encodedFormats = formatsFromString(encodedFormatsLiteral, " "); } - Element deviceDesc = new DeviceDescriptor(type, encodedFormats, String8(name.c_str())); + Element deviceDesc = new DeviceDescriptor(type, encodedFormats, String8(strdup(name.c_str()))); std::string address = getXmlAttribute(cur, Attributes::address); if (!address.empty()) { -- 2.17.1