From d39466c50305a64ff3a683b1e13373379273ee57 Mon Sep 17 00:00:00 2001 From: Andy CrossGate Yan Date: Mon, 20 Nov 2023 22:00:14 +0800 Subject: [PATCH 1/2] Revert "CompositionEngine: Request device composition for the Udfps touched layer" This reverts commit 69fad8aa4098b007fe17472902159705fdcd957f. --- .../CompositionEngine/src/Output.cpp | 16 +--------------- 1 file changed, 1 insertion(+), 15 deletions(-) diff --git a/services/surfaceflinger/CompositionEngine/src/Output.cpp b/services/surfaceflinger/CompositionEngine/src/Output.cpp index f680fc5eac..09c7c9933a 100644 --- a/services/surfaceflinger/CompositionEngine/src/Output.cpp +++ b/services/surfaceflinger/CompositionEngine/src/Output.cpp @@ -22,7 +22,6 @@ #include #include #include -#include #include #include #include @@ -915,10 +914,7 @@ void Output::writeCompositionState(const compositionengine::CompositionRefreshAr compositionengine::OutputLayer* Output::findLayerRequestingBackgroundComposition() const { compositionengine::OutputLayer* layerRequestingBgComposition = nullptr; - for (size_t i = 0; i < getOutputLayerCount(); i++) { - compositionengine::OutputLayer* layer = getOutputLayerOrderedByZByIndex(i); - compositionengine::OutputLayer* nextLayer = getOutputLayerOrderedByZByIndex(i + 1); - + for (auto* layer : getOutputLayersOrderedByZ()) { const auto* compState = layer->getLayerFE().getCompositionState(); // If any layer has a sideband stream, we will disable blurs. In that case, we don't @@ -938,16 +934,6 @@ compositionengine::OutputLayer* Output::findLayerRequestingBackgroundComposition if (compState->backgroundBlurRadius > 0 || compState->blurRegions.size() > 0) { layerRequestingBgComposition = layer; } - - // If the next layer is the Udfps touched layer, enable client composition for it - // because that somehow leads to the Udfps touched layer getting device composition - // consistently. - if ((nextLayer != nullptr && layerRequestingBgComposition == nullptr) && - (strncmp(nextLayer->getLayerFE().getDebugName(), UDFPS_TOUCHED_LAYER_NAME, - strlen(UDFPS_TOUCHED_LAYER_NAME)) == 0)) { - layerRequestingBgComposition = layer; - break; - } } return layerRequestingBgComposition; } -- 2.34.1